Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let an invalid project definition file break telemetry #1660

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Don't let an invalid project definition file break telemetry #1660

merged 2 commits into from
Oct 3, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Use bug report, when running snow object create (a command that shouldn't load snowflake.yml), a Pydantic validation error was still raised because the file is loaded by telemetry code to get the definition version. We shouldn't let telemetry code break the app, so let's just ignore the error in the case of an invalid project definition.

@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 2, 2024 16:41
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 2, 2024 17:36
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit ddb6180 into main Oct 3, 2024
21 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-bad-pdf-dont-break-telemetry branch October 3, 2024 13:18
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-fcampbell
Don't let an invalid project definition file break telemetry (#1660)
2723509 
When running `snow object create` (a command that shouldn't load `snowflake.yml`), a Pydantic validation error was still raised because the file is loaded by telemetry code to get the definition version. We shouldn't let telemetry code break the app, so let's just ignore the error in the case of an invalid project definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-turbaszek